Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120408 --- Ship it! Tested with mesos-execute

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

- Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120273 --- On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote: > >

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

> On Feb. 23, 2016, 7:41 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 258 > > > > > > Not yours but do we need a CHECK here or a graceful failure.

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

> On Feb. 23, 2016, 7:45 a.m., Guangya Liu wrote: > > Some doc may also need to be changed by removing the ssl related > > configurations, such as > > > > https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md > >

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

> On Feb. 23, 2016, 7:27 p.m., Gilbert Song wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 1267 > > > > > > Could we do `EXPECT_EQ(2u, imageInfo->layers.size())` ? We don't know that for

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- (Updated Feb. 23, 2016, 8:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- (Updated Feb. 23, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120367 ---

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120364 --- The patch looks good to me. Could you rebase? I want to apply the

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120314 --- Bad patch! Reviews applied: [43860, 43801] Failed command:

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120273 --- Some doc may also need to be changed by removing the ssl related

Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs: