Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review121061 --- The document monitoring.md and some test cases are also needed.

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120860 --- Ship it! Ship It! - haosdent huang On Feb. 26, 2016, 7:19

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread fan du
> On 二月 26, 2016, 9:34 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [44058] > > > > Failed command: ./support/apply-review.sh -n -r 44058 > > > > Error: > > 2016-02-26 09:34:14 URL:https://reviews.apache.org/r/44058/diff/raw/ > > [4122/4122] -> "44058.patch" [1] > >

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120849 --- Bad patch! Reviews applied: [44058] Failed command:

Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-25 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/ --- Review request for mesos, Greg Mann, haosdent huang, and Jie Yu. Bugs: