Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-15 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 15, 2016, 7:11 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-15 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 15, 2016, 6:32 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-14 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 15, 2016, 1:25 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-12 Thread Alex Naparu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/#review128553
---


Ship it!




Ship It!

- Alex Naparu


On April 11, 2016, 4:21 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44131/
> ---
> 
> (Updated April 11, 2016, 4:21 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d2c458ed93307f75358bb642aaf2ed8e17b2fe97 
> 
> Diff: https://reviews.apache.org/r/44131/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-12 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/#review128419
---


Fix it, then Ship it!





3rdparty/libprocess/src/process.cpp (line 2193)


If it returns a try, you should test for error.


- Joris Van Remoortere


On April 11, 2016, 4:21 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44131/
> ---
> 
> (Updated April 11, 2016, 4:21 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d2c458ed93307f75358bb642aaf2ed8e17b2fe97 
> 
> Diff: https://reviews.apache.org/r/44131/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-10 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 11, 2016, 4:21 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing (updated)
---

OSX: make check


Thanks,

Daniel Pravat