Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

2016-03-30 Thread Michael Park
> On March 22, 2016, 9:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

2016-03-23 Thread Gilbert Song
> On March 22, 2016, 2:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

2016-03-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44136/ --- (Updated March 23, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu,