Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-25 Thread Vinod Kone
> On March 24, 2016, 7:16 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [44372] > > > > Failed command: ./support/apply-review.sh -n -r 44372 > > > > Error: > > 2016-03-24 07:16:51 URL:https://reviews.apache.org/r/44372/diff/raw/ > > [104639/104639] -> "44372.patch"

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review125224 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread haosdent huang
> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Joseph Wu
> On March 21, 2016, 7:35 p.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 24, 2016, 9:13 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread haosdent huang
> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-23 Thread Vinod Kone
> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124762 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-21 Thread Zhiwei Chen
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 --- Hi, zhiwei. Thank you for your patch. But seems it still doesn't

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-21 Thread haosdent huang
> On March 4, 2016, 7:37 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > > > > > ditto. > > Zhiwei Chen wrote: > In the real file, there is a table bracket and backslash. I

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-21 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 22, 2016, 10:22 a.m.) Review request for mesos, Ben Mahler,