Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 13, 2016, 10:29 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, lines 103-104 > > > > > > Why have you removed the TODO without adding a word about how `command` > > works wiht containers? Alex,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128680 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128646 --- src/cli/execute.cpp

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 104 > > > > > > Do we introduce 'arguments' flag? It looks like you treat 'command' > > flag as command + arguments. This comment

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 13, 2016, 2:47 a.m.) Review request for mesos, Alexander

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128216 --- src/cli/execute.cpp (line 306)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128041 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 10, 2016, 1:12 p.m.) Review request for mesos, Alexander

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128027 --- src/cli/execute.cpp (line 94)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 4, 2016, 6:13 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 287 > > > > > > This is incorrect. We handle this merging operation in runtime isolator. > > Tim Anderegg wrote: > I was testing out

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On April 4, 2016, 6:13 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 287 > > > > > > This is incorrect. We handle this merging operation in runtime isolator. I was testing out a similar implementation

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126880 --- src/cli/execute.cpp (line 284)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 3, 2016, 9:52 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 283 > > > > > > According to "testing done" section, the separator is comma. How come > > here is space? > > > > Also,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 104 > > > > > > Do we introduce 'arguments' flag? It looks like you treat 'command' > > flag as command + arguments. This comment

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 3, 2016, 1:42 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On April 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". Yeah,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126720 --- src/cli/execute.cpp (line 283)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126719 --- src/cli/execute.cpp (line 104)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 2, 2016, 3:01 p.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On April 2, 2016, 2:38 p.m., haosdent huang wrote: > > By the way, use comma "," as delimiter looks a bit wired. Usually we use space or tab " ", right? - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126690 --- src/cli/execute.cpp (line 283)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126244 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 三月 31, 2016, 1:03 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122740 --- Ship it! Ship It! - Gilbert Song On March 7, 2016, 9:17

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122487 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 三月 8, 2016, 5:17 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 三月 7, 2016, 4:48 p.m., Gilbert Song wrote: > > Hi Guangya, Thanks for taking this on. My main consideration about this > > patch is making distinction between shell command v.s. non-shell command. > > We have two choices: > > > > 1. Following your current implementation, the description

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122305 --- Hi Guangya, Thanks for taking this on. My main consideration

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122273 --- Patch looks great! Reviews applied: [1] Passed command:

Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4882