Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125889 --- Fix it, then Ship it!

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 29, 2016, 6:58 p.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 29, 2016, 1:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 354 > > > > > > Should we return a Failure here instead? I think we should not return a Failure

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 29, 2016, 3:04 p.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125825 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125824 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 25, 2016, 12:20 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 438 > > > > > > Why do you need to get os::environment()? > > Qian Zhang wrote: > The reason

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 26, 2016, 10:53 p.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 25, 2016, 8:20 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 438 > > > > > > Why do you need to get os::environment()? The reason is, CNI plugin needs to call

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 445 > > > > > > Why the `CHECK_READY` here ? If the future is not READY it could be in

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125367 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 328-336 > > > > > > why do we need this dispatch ? The dispatch is to itself, so seems

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 471 > > > > > > Again why the CHECK ? The result might not have an IPv4 or an IPv6 > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 3:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > This is just a thought. Maybe its better to use `await` over here, and

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 3:08 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 32-56 > > > > > > Can we introduce paths.hpp|cpp under cni/ directory for the canonical > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124554 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124460 --- Some initial comments. Will do a pass to finish the rest later.

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 21, 2016, 12:27 a.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 277 > > > > > > either s/realpath/`realpath` > > > > or s/realpath/location I see

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 11, 2016, 6:45 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 16, 2016, 3:50 p.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 11, 2016, 6:45 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123181 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123150 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: