Re: Review Request 44719: Avoided external linkage for slave constants.

> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > src/slave/constants.hpp, lines 116-118 > > > > > > Can this be in-line or is there a circular dependency issue that > > warrants the .cpp file? This can be in t

Re: Review Request 44719: Avoided external linkage for slave constants.

> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > I'll make sure the commit description provides the similar motivation as was provided in https://reviews.apache.org/r/44191/ (although referring to the latest project style guidelines rather than performance). - Ben

Re: Review Request 44719: Avoided external linkage for slave constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/#review123258 --- Ship it! src/slave/constants.hpp (lines 110 - 112)

Review Request 44719: Avoided external linkage for slave constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --