Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-19 Thread Neil Conway
> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
> On March 16, 2016, 12:25 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > "don't". Also, we should use backticks for `FTS_COMFOLLOW` for > > cons

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jie Yu
> On March 16, 2016, 12:25 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > "don't". Also, we should use backticks for `FTS_COMFOLLOW` for > > cons

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jie Yu
> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123803 --- 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123802 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.h

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123798 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 11:47 p.m., Jo

Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos Descripti