Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 20, 2016, 5:35 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124159 --- "The test is slowed considerably" - Can you provide some stats on

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 17, 2016, 11:16 p.m., Neil Conway wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Style-wise, do we want all tests to resume if they initially pause it? > > I think we do a mix of

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 4:35 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 2:48 a.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 6:55 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124116 --- src/tests/resource_offers_tests.cpp (line 63)

Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-4849

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 6:52 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 1 a.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124395 --- src/tests/resource_offers_tests.cpp (line 77)

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124390 --- src/tests/resource_offers_tests.cpp (lines 84 - 85)

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 2:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > "The test is slowed considerably" - Can you provide some stats on how fast > > it is before/after the patch? Good call - timing information has been added, and it actually wasn't as bad as I thought. - Greg

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 12:16 a.m., Neil Conway wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Style-wise, do we want all tests to resume if they initially pause it? > > I think we do a mix of