Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126917 --- Fix it, then Ship it! Thanks for taking this on! I'll fix remai

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126909 --- Ship it! Ship It! - Vinod Kone On April 4, 2016, 3:21 p.m.,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126895 --- Ship it! Ship It! - Kevin Klues On April 4, 2016, 3:21 p.m.,

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 3:21 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 10:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 113 > > > > > > Nit-pick: We do not have a Python style, but e.g., the Google Python > > style guide would set `if` right below

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 2:31 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126806 --- Fix it, then Ship it! support/mesos-style.py (line 113)

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 3, 2016, 10:13 p.m., Kevin Klues wrote: > > Thanks Yong! > > > > Patch looks great now. The only thing I'd change at this point is the > > wording in the commit message. > > > > Probably something like: > > ``` > > Add a commit hook for checking non-printable characters (MESOS-4033

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126772 --- Ship it! Ship It! - haosdent huang On April 3, 2016, 11:45 p

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 3, 2016, 11:45 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 3, 2016, 10:13 p.m., Kevin Klues wrote: > > Thanks Yong! > > > > Patch looks great now. The only thing I'd change at this point is the > > wording in the commit message. > > > > Probably something like: > > ``` > > Add a commit hook for checking non-printable characters (MESOS-4033