Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130311 --- Ship it! Ship It! - Jie Yu On April 24, 2016, 9:44 a.m.,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 24, 2016, 9:44 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the mount

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130293 ---

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130287 ---

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130286 ---

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 23, 2016, 7:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 242 > > > > > > YOu can iterate through `volumeInfos` here. > > Guangya Liu wrote: > You

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? > > Guangya

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? The problem is

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130133 ---

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 22, 2016, 6:36 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 21, 2016, 9:36 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should we use a hashset for `dockerVolumeInfos`? > > > > I am

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 21, 2016, 9:36 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should we use a hashset for `dockerVolumeInfos`? > > > > I am

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 13, 2016, 9:05 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 106 > > > > > > we should probably validate (or else sanitize) the contents of driver, > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review129959 --- Thanks Guangya! This is great! Need to do one more pass later.

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 21, 2016, 2:21 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128946 ---

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 14, 2016, 6:29 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 13, 2016, 9:05 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 106 > > > > > > we should probably validate (or else sanitize) the contents of driver, > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 5, 2016, 5:47 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 110 > > > > > > ``` > > foreach (const string& driverOption, > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 13, 2016, 8:54 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 113 > > > > > > other `--flag` params are computed elsewhere (e.g. DvdClient::mount); > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,