Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127897 --- Ship it! Ship It! - Vinod Kone On April 6, 2016, 11:19

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

> On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > As discussed offline, lets add TODOs for metrics to defer the gauges to > scheduler process. Mark the issues as fixed here, so that we can focus the discussion on the last review in the chain. - Vinod

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

> On April 6, 2016, 11:55 a.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 272 > > > > > > s/counter/metrics/ > > > > I'm assuming you might want to add gauge type metrics to this

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

> On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 272 > > > > > > s/counter/metrics/ > > > > I'm assuming you might want to add gauge type metrics to this

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

> On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > As discussed offline, lets add TODOs for metrics to defer the gauges to scheduler process. - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 4:19 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 3:34 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 3:16 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

> On April 6, 2016, 11:55 a.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 241 > > > > > > Looking at the code below I think it makes more sense to make > > LongLivedScheduler an instance of

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127404 --- src/examples/long_lived_framework.cpp (line 92)

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127262 --- Patch looks great! Reviews applied: [45067, 45440] Passed

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 5, 2016, 3:33 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review126011 --- Patch looks great! Reviews applied: [45067, 45440] Passed

Review Request 45440: Added some metrics to the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod