Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On March 31, 2016, 2:03 a.m., Jie Yu wrote: > > This is a high level question: I am now sure if adding attributes is safe > > or not. For instance, my framework has the following rule: only schedule > > tasks to agents that do not have attribute "not_safe". Now, say agent A is > > initially

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On March 30, 2016, 2:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s)

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On 三月 31, 2016, 2:03 a.m., Jie Yu wrote: > > This is a high level question: I am now sure if adding attributes is safe > > or not. For instance, my framework has the following rule: only schedule > > tasks to agents that do not have attribute "not_safe". Now, say agent A is > > initially

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126242 --- This is a high level question: I am now sure if adding attributes

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126118 --- Patch looks great! Reviews applied: [45474] Passed command:

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s)

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126066 --- src/tests/slave_tests.cpp (lines 3541 - 3545)

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On March 30, 2016, 6:52 a.m., haosdent huang wrote: > > I think the better place to put this test case is > > `slave_recovery_tests.cpp`. > > Deshi Xiao wrote: > i don't think so. the test aim to focus on reconfiguration from restart > slave. it doesn't care the recovery state. Got it.

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On 三月 30, 2016, 6:52 a.m., haosdent huang wrote: > > I think the better place to put this test case is > > `slave_recovery_tests.cpp`. i don't think so. the test aim to focus on reconfiguration from restart slave. it doesn't care the recovery state. - Deshi

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126045 --- src/tests/slave_tests.cpp (line 3558)

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/ --- (Updated 三月 30, 2016, 6:52 a.m.) Review request for mesos. Bugs: MESOS-1739

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126042 --- I think the better place to put this test case is

Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/ --- Review request for mesos. Bugs: MESOS-1739