Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Guangya Liu]

> On March 31, 2016, 2:03 a.m., Jie Yu wrote:
> > This is a high level question: I am now sure if adding attributes is safe 
> > or not. For instance, my framework has the following rule: only schedule 
> > tasks to agents that do not have attribute "not_safe". Now, say agent A is 
> > initially without that attribute. My framework lands several tasks on that 
> > agent. Later, when agent restarts, the operator adds the new attribute 
> > "not_safe". Suddently, i have tasks running on unsafe boxes. oops.
> 
> Deshi Xiao wrote:
> I think so, this is very common case. it need more detail discussion with 
> team.

It's difficult to handle such issue as the operation are issued by 
administrator, but the tasks are launched by framework developers. I can see 
for most of such cases, just left the old tasks running on the agent till 
finished but the new tasks will launch on other agents other than this agent.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126242
---


On March 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Adam B]

> On March 30, 2016, 2:08 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 3541-3545
> > 
> >
> > Here you shutdown the slave and wait (you'll probably want to advance 
> > the clock rather than wait for 90s) for the slave to be declared 
> > SLAVE_LOST. Once this occurs, the master will no longer allow the slave to 
> > reregister with the same slaveId, and the slave will be told to kill all 
> > running tasks. The slave will do so and then restart and register as a new 
> > slaveId. 
> > This is what is meant by the quote from the design doc: "Currently this 
> > can only be handled by stopping / draining a mesos slave entirely (Killing 
> > all of its running jobs), removing it from the cluster, then bringing it 
> > back up as a brand new slave."
> > 
> > To truly observe this behavior, you should start a task on the slave 
> > before you shut it down. Then you will see a TASK_LOST and the task will be 
> > killed.
> 
> Deshi Xiao wrote:
> Thanks Adam, i will udpate the test case.
> 
> Deshi Xiao wrote:
> @Adam B
> Here i have a confuse,need your guide. use test case to track the 
> TASK_LOST in restart slave. do we expect keep the slave_id is not outdate?

Desired behavior: Operator can kill a slave process and restart it with new 
--attributes. Existing tasks will continue to run. No TASK_LOST or SLAVE_LOST 
message is sent. The slaveId remains the same. Outstanding offers from that 
slave will be rescinded, and those offers will be remade with the updated 
attributes.
Current behavior 1: Operator shuts down a slave process, and restarts with 
--recover=cleanup, which kills all its tasks, clears the work_dir, and notifies 
the master that the old slaveId is "shutdown" and will never be reused again 
(SLAVE_LOST, offers rescinded, TASK_KILLED/LOST). Operator then restarts the 
slave with new --attributes, it gets a new slaveId, and new offers will be made 
with the new slaveId and updated attributes.
Current behavior 2: Slave process dies/killed and tries to restart with new 
--attributes. Errors on recovery.
Current behavior 3: Slave process dies/killed and doesn't reregister in 
`slave_ping_timeout*max_slave_ping_timeouts` (90s). Master considers it gone, 
sends SLAVE_LOST, TASK_LOST. Future attempts to reregister with the same 
slaveId fail. Slave must be cleaned up (tasks killed, work_dir removed) so it 
can register with a new slaveId (and new attributes).


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
---


On March 30, 2016, 1:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

> On 三月 30, 2016, 9:08 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 3541-3545
> > 
> >
> > Here you shutdown the slave and wait (you'll probably want to advance 
> > the clock rather than wait for 90s) for the slave to be declared 
> > SLAVE_LOST. Once this occurs, the master will no longer allow the slave to 
> > reregister with the same slaveId, and the slave will be told to kill all 
> > running tasks. The slave will do so and then restart and register as a new 
> > slaveId. 
> > This is what is meant by the quote from the design doc: "Currently this 
> > can only be handled by stopping / draining a mesos slave entirely (Killing 
> > all of its running jobs), removing it from the cluster, then bringing it 
> > back up as a brand new slave."
> > 
> > To truly observe this behavior, you should start a task on the slave 
> > before you shut it down. Then you will see a TASK_LOST and the task will be 
> > killed.
> 
> Deshi Xiao wrote:
> Thanks Adam, i will udpate the test case.

@Adam B
Here i have a confuse,need your guide. use test case to track the TASK_LOST in 
restart slave. do we expect keep the slave_id is not outdate?


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
---


On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated 三月 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

> On 三月 31, 2016, 2:03 a.m., Jie Yu wrote:
> > This is a high level question: I am now sure if adding attributes is safe 
> > or not. For instance, my framework has the following rule: only schedule 
> > tasks to agents that do not have attribute "not_safe". Now, say agent A is 
> > initially without that attribute. My framework lands several tasks on that 
> > agent. Later, when agent restarts, the operator adds the new attribute 
> > "not_safe". Suddently, i have tasks running on unsafe boxes. oops.

I think so, this is very common case. it need more detail discussion with team.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126242
---


On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated 三月 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126242
---



This is a high level question: I am now sure if adding attributes is safe or 
not. For instance, my framework has the following rule: only schedule tasks to 
agents that do not have attribute "not_safe". Now, say agent A is initially 
without that attribute. My framework lands several tasks on that agent. Later, 
when agent restarts, the operator adds the new attribute "not_safe". Suddently, 
i have tasks running on unsafe boxes. oops.

- Jie Yu


On March 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126118
---



Patch looks great!

Reviews applied: [45474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

> On 三月 30, 2016, 9:08 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 3541-3545
> > 
> >
> > Here you shutdown the slave and wait (you'll probably want to advance 
> > the clock rather than wait for 90s) for the slave to be declared 
> > SLAVE_LOST. Once this occurs, the master will no longer allow the slave to 
> > reregister with the same slaveId, and the slave will be told to kill all 
> > running tasks. The slave will do so and then restart and register as a new 
> > slaveId. 
> > This is what is meant by the quote from the design doc: "Currently this 
> > can only be handled by stopping / draining a mesos slave entirely (Killing 
> > all of its running jobs), removing it from the cluster, then bringing it 
> > back up as a brand new slave."
> > 
> > To truly observe this behavior, you should start a task on the slave 
> > before you shut it down. Then you will see a TASK_LOST and the task will be 
> > killed.

Thanks Adam, i will udpate the test case.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
---


On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated 三月 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
---




src/tests/slave_tests.cpp (lines 3541 - 3545)


Here you shutdown the slave and wait (you'll probably want to advance the 
clock rather than wait for 90s) for the slave to be declared SLAVE_LOST. Once 
this occurs, the master will no longer allow the slave to reregister with the 
same slaveId, and the slave will be told to kill all running tasks. The slave 
will do so and then restart and register as a new slaveId. 
This is what is meant by the quote from the design doc: "Currently this can 
only be handled by stopping / draining a mesos slave entirely (Killing all of 
its running jobs), removing it from the cluster, then bringing it back up as a 
brand new slave."

To truly observe this behavior, you should start a task on the slave before 
you shut it down. Then you will see a TASK_LOST and the task will be killed.


- Adam B


On March 30, 2016, 1:13 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[haosdent huang]

> On March 30, 2016, 6:52 a.m., haosdent huang wrote:
> > I think the better place to put this test case is 
> > `slave_recovery_tests.cpp`.
> 
> Deshi Xiao wrote:
> i don't think so. the test aim to focus on reconfiguration from restart 
> slave. it doesn't care the recovery state.

Got it. You reason make sense.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126042
---


On March 30, 2016, 7:03 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 7:03 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

> On 三月 30, 2016, 6:52 a.m., haosdent huang wrote:
> > I think the better place to put this test case is 
> > `slave_recovery_tests.cpp`.

i don't think so. the test aim to focus on reconfiguration from restart slave. 
it doesn't care the recovery state.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126042
---


On 三月 30, 2016, 7:03 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated 三月 30, 2016, 7:03 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126045
---




src/tests/slave_tests.cpp (line 3558)


`Wait for offers.`


- haosdent huang


On March 30, 2016, 6:52 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 6:52 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/
---

(Updated 三月 30, 2016, 6:52 a.m.)


Review request for mesos.


Bugs: MESOS-1739
https://issues.apache.org/jira/browse/MESOS-1739


Repository: mesos


Description
---

Phase 1
Make SlaveInfo mutable throughout the stack, and allow for expansion of 
resources and attributes only (Which allows testing to make sure it propagates 
to the allocator, shows up in offers, etc). Ensure there is unified checking 
for incompatibilities in both the slave and master (the slave should validate 
the config, the master should validate that all operations the slave takes are 
legal).

it derived from another PR(https://reviews.apache.org/r/25525/)


Diffs (updated)
-

  src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 

Diff: https://reviews.apache.org/r/45474/diff/


Testing
---

make check on localhost


Thanks,

Deshi Xiao

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126042
---



I think the better place to put this test case is `slave_recovery_tests.cpp`.


src/tests/slave_tests.cpp (line 3488)


I think could remove all `this->`.



src/tests/slave_tests.cpp (line 3543)


I think could remove `slave->reset();` here.


- haosdent huang


On March 30, 2016, 6:35 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> ---
> 
> (Updated March 30, 2016, 6:35 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of 
> resources and attributes only (Which allows testing to make sure it 
> propagates to the allocator, shows up in offers, etc). Ensure there is 
> unified checking for incompatibilities in both the slave and master (the 
> slave should validate the config, the master should validate that all 
> operations the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>

Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/
---

Review request for mesos.


Bugs: MESOS-1739
https://issues.apache.org/jira/browse/MESOS-1739


Repository: mesos


Description
---

Phase 1
Make SlaveInfo mutable throughout the stack, and allow for expansion of 
resources and attributes only (Which allows testing to make sure it propagates 
to the allocator, shows up in offers, etc). Ensure there is unified checking 
for incompatibilities in both the slave and master (the slave should validate 
the config, the master should validate that all operations the slave takes are 
legal).

it derived from another PR(https://reviews.apache.org/r/25525/)


Diffs
-

  src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 

Diff: https://reviews.apache.org/r/45474/diff/


Testing
---

make check on localhost


Thanks,

Deshi Xiao