Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127836
---


Ship it!




Ship It!

- Vinod Kone


On April 8, 2016, 9:21 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 8, 2016, 9:21 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127767
---



Patch looks great!

Reviews applied: [45803]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 9:21 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 8, 2016, 9:21 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-08 Thread Zhiwei Chen 


> On April 8, 2016, 6 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 84
> > 
> >
> > gcc is installed by `build-essential`. don't you want to install clang 
> > like we did above?

clang does not exist on ubuntu ppc64le, but the clang-3.5 and clang 3.6 exists. 
I tested with v3.5 and v3.6, both of them can't work on Power, so I disabled 
clang on Power.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127676
---


On April 6, 2016, 5:25 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 6, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-08 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/
---

(Updated April 8, 2016, 5:21 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4897
https://issues.apache.org/jira/browse/MESOS-4897


Repository: mesos


Description
---

Add PowerPC LE CI for support/docker_build.sh.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45803/diff/


Testing
---

On a PowerPC machine, run following command:

ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh


Thanks,

Zhiwei Chen

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127676
---




support/docker_build.sh (lines 71 - 92)


Instead of copy pasting how about changing the `ubuntu*` case above to 
`*ubuntu*`



support/docker_build.sh (line 84)


gcc is installed by `build-essential`. don't you want to install clang like 
we did above?


- Vinod Kone


On April 6, 2016, 9:25 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 6, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127380
---



Patch looks great!

Reviews applied: [45803]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 6, 2016, 9:25 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 6, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-06 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4897
https://issues.apache.org/jira/browse/MESOS-4897


Repository: mesos


Description
---

Add PowerPC LE CI for support/docker_build.sh.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45803/diff/


Testing
---

On a PowerPC machine, run following command:

ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh


Thanks,

Zhiwei Chen