Re: Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos, Anurag Singh and Jie Yu. Changes --- rebased Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Removed unsed headers from master contender/detector files. Diffs (updated) - src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/#review128813 --- Ship it! Ship It! - Jie Yu On April 13, 2016, 8:06 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45901/ > --- > > (Updated April 13, 2016, 8:06 p.m.) > > > Review request for mesos, Anurag Singh and Jie Yu. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > Removed unsed headers from master contender/detector files. > > > Diffs > - > > src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 > src/master/contender/standalone.hpp > 511165c8b355ac9732c2e8921e12545c7c6217ed > src/master/contender/standalone.cpp > 18959510338c0f2c5b2df254845c119902ff538f > src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 > src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba > src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 > src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 > src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee > src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 > src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 > src/tests/master_contender_detector_tests.cpp > 1426a173b1f458d67b748016aee311ac008b054a > > Diff: https://reviews.apache.org/r/45901/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
Re: Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 13, 2016, 4:06 p.m.) Review request for mesos, Anurag Singh and Jie Yu. Changes --- rebased Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Removed unsed headers from master contender/detector files. Diffs (updated) - src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/#review128058 --- Patch looks great! Reviews applied: [45900, 45901] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 11, 2016, 12:50 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45901/ > --- > > (Updated April 11, 2016, 12:50 a.m.) > > > Review request for mesos and Anurag Singh. > > > Repository: mesos > > > Description > --- > > Removed unsed headers from master contender/detector files. > > > Diffs > - > > src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 > src/master/contender/standalone.hpp > 511165c8b355ac9732c2e8921e12545c7c6217ed > src/master/contender/standalone.cpp > 18959510338c0f2c5b2df254845c119902ff538f > src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 > src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba > src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 > src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 > src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee > src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 > src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 > src/tests/master_contender_detector_tests.cpp > 1426a173b1f458d67b748016aee311ac008b054a > > Diff: https://reviews.apache.org/r/45901/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
Re: Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 10, 2016, 8:50 p.m.) Review request for mesos and Anurag Singh. Changes --- Fixed compilation error with java. Repository: mesos Description (updated) --- Removed unsed headers from master contender/detector files. Diffs (updated) - src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya
Review Request 45901: Removed unsed headers from master contender/detector files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- Review request for mesos and Anurag Singh. Repository: mesos Description --- See summary. Diffs - src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya
