Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review136956 --- Patch looks great! Reviews applied: [46407, 48299, 45604, 46411,

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated June 9, 2016, 4:55 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review136550 --- Fix it, then Ship it! src/examples/balloon_framework.cpp (line

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review136399 --- Patch looks great! Reviews applied: [46407, 48299, 45604, 46411,

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-06 Thread Joseph Wu
> On April 21, 2016, 2:40 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, line 389 > > > > > > Why do you need to store this? With the process split, we don't need to store it anymore. > On April 2

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated June 6, 2016, 5:30 p.m.) Review request for mesos, Greg Mann, Artem Ha

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review129966 --- src/examples/balloon_framework.cpp (line 296)

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review129682 --- Patch looks great! Reviews applied: [46407, 45604, 46411, 45905]

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 19, 2016, 2:52 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review129012 --- Bad patch! Reviews applied: [45905, 45604] Failed command: ./sup

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 14, 2016, 2:43 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 11, 2016, 11:24 a.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review127952 --- Bad patch! Reviews applied: [45905, 45604] Failed command: ./sup

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 8, 2016, 5:32 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review127719 --- Bad patch! Reviews applied: [45905, 45604] Failed command: ./sup

Review Request 45905: Added metrics to the balloon framework.

2016-04-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod K