Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-11 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/#review128307
---


Ship it!





src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 217 - 223)


How about no newlines between these since they are related?


- Ben Mahler


On April 11, 2016, 10:18 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45970/
> ---
> 
> (Updated April 11, 2016, 10:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5159
> https://issues.apache.org/jira/browse/MESOS-5159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Nvidia GPU test to verify error when requesting fractional GPUs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 
> 
> Diff: https://reviews.apache.org/r/45970/diff/
> 
> 
> Testing
> ---
> 
> ```
> make -j check
> SUCCESS
> ```
> ```
> [klueska@core-dev build]$ sudo 
> GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
> bin/mesos-tests.sh
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from NvidiaGpuTest
> [ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
> [   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10020 
> ms)
> [--] 1 test from NvidiaGpuTest (10026 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (10059 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/#review128298
---



Patch looks great!

Reviews applied: [45969, 46053, 45970]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 11, 2016, 10:18 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45970/
> ---
> 
> (Updated April 11, 2016, 10:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5159
> https://issues.apache.org/jira/browse/MESOS-5159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Nvidia GPU test to verify error when requesting fractional GPUs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 
> 
> Diff: https://reviews.apache.org/r/45970/diff/
> 
> 
> Testing
> ---
> 
> ```
> make -j check
> SUCCESS
> ```
> ```
> [klueska@core-dev build]$ sudo 
> GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
> bin/mesos-tests.sh
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from NvidiaGpuTest
> [ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
> [   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10020 
> ms)
> [--] 1 test from NvidiaGpuTest (10026 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (10059 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-11 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/
---

(Updated April 11, 2016, 10:18 p.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
---

Updated test to rely on changes in 46053


Bugs: MESOS-5159
https://issues.apache.org/jira/browse/MESOS-5159


Repository: mesos


Description
---

Added Nvidia GPU test to verify error when requesting fractional GPUs.


Diffs (updated)
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 

Diff: https://reviews.apache.org/r/45970/diff/


Testing (updated)
---

```
make -j check
SUCCESS
```
```
[klueska@core-dev build]$ sudo 
GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
bin/mesos-tests.sh
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from NvidiaGpuTest
[ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
[   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10020 
ms)
[--] 1 test from NvidiaGpuTest (10026 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (10059 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Kevin Klues

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/#review127948
---



Patch looks great!

Reviews applied: [45969, 45970]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 11:33 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45970/
> ---
> 
> (Updated April 8, 2016, 11:33 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5159
> https://issues.apache.org/jira/browse/MESOS-5159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Nvidia GPU test to verify error when requesting fractional GPUs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 
> 
> Diff: https://reviews.apache.org/r/45970/diff/
> 
> 
> Testing
> ---
> 
> ```
> [klueska@core-dev build]$ sudo 
> GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
> bin/mesos-tests.sh
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from NvidiaGpuTest
> [ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
> [   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10184 
> ms)
> [--] 1 test from NvidiaGpuTest (10191 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (10260 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-08 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45970/
---

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Bugs: MESOS-5159
https://issues.apache.org/jira/browse/MESOS-5159


Repository: mesos


Description
---

Added Nvidia GPU test to verify error when requesting fractional GPUs.


Diffs
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
dfffb2cf4d1d9c1f2de4ad90ce3d8acc3e98631c 

Diff: https://reviews.apache.org/r/45970/diff/


Testing
---

```
[klueska@core-dev build]$ sudo 
GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources" 
bin/mesos-tests.sh
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from NvidiaGpuTest
[ RUN  ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources
[   OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_FractionalResources (10184 
ms)
[--] 1 test from NvidiaGpuTest (10191 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (10260 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Kevin Klues