Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 21, 2016, 4:07 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129642 --- Ship it! Ship It! - Michael Park On April 18, 2016, 7:09

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 18, 2016, 7:09 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 17, 2016, 10:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 15, 2016, 11:31 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 362 > > > > > > What's the difference between `Failed to call X` vs `Call to `X` > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129204 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 14, 2016, 9:10 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183 > > > > > > (1) It seems like this should live in `posix/os.hpp`. > > (2) The

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129192 --- Ship it! Ship It! - Michael Park On April 15, 2016, 7:50

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 14, 2016, 9:10 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183 > > > > > > (1) It seems like this should live in `posix/os.hpp`. > > (2) The

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 15, 2016, 7:50 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128983 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 14, 2016, 8:57 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128781 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 10:06 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383 > > > > > > Can you document this flag a bit please? GetProcessTimes requires > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383 > > > > > > Can you document this flag a bit please? GetProcessTimes requires > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 9:49 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > Hey, sorry, you reviewed an old version of the code. I had a different branch checked out when I pushed this. The background is that this is an amalgamation of maybe 3 or 4 commits, and the code is not amazing. I went through and fixed

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 9:33 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128565 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 11, 2016, 7:19 p.m.) Review request for mesos, Alex Naparu,

Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris