Re: Review Request 46028: Improved comments in SocketManager::next().

2016-09-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review148884 --- Closing this review due to inactivity. Please see our

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-06-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review138340 --- Could you split the patch into two? ``` Documented

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- (Updated June 16, 2016, 8:55 a.m.) Review request for mesos and Benjamin

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- (Updated April 11, 2016, 11:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
> On April 11, 2016, 10:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1947-1954 > > > > > > The implication of this comment (regardless of your changes) seems to > > be that the socket

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review128267 --- 3rdparty/libprocess/src/process.cpp (lines 1813 - 1816)

Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- Review request for mesos and Ben Mahler. Repository: mesos Description