Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review129884 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2016,

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/ --- (Updated April 20, 2016, 8 a.m.) Review request for mesos, Adam B and

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
> On April 14, 2016, 10:45 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > +1 to using Future with FutureSatisfy since you're not > > validating the contents of the Resources.

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > If you're not doing any checks with resources, you can use > > `Future` instead. > >

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128872 --- Looks good. Fix these issues (mine and AlexR's) and we can commit

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Alexander Rukletsov
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > If you're not doing any checks with resources, you can use > > `Future` instead. > >

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Yongqiao Wang
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1637 > > > > > > You don't need this `settle()`. According to my understanding, call Clock::settle() after

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128640 --- src/tests/master_allocator_tests.cpp (line 1604)

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128634 --- Patch looks great! Reviews applied: [46135] Passed command:

Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-12 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-5146