Re: Review Request 46173: Added a slave post fetch hook.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46173/#review128777
---


Ship it!





src/hook/manager.cpp (lines 243 - 244)


Would you mind getting the quotes on the same line?

```
LOG(WARNING) << "Failed to execute slave post fetch hook for module"
 << " '" << name << "': " << result.error();
```


- Ben Mahler


On April 13, 2016, 10:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46173/
> ---
> 
> (Updated April 13, 2016, 10:30 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5209
> https://issues.apache.org/jira/browse/MESOS-5209
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a slave post fetch hook.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 87e01a9dccb04bfdd5395867a45c46574815731b 
>   src/hook/manager.hpp 3af28a76493a95a3427fecb3a23dd80ecb84dfe9 
>   src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
>   src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 
> 
> Diff: https://reviews.apache.org/r/46173/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 46173: Added a slave post fetch hook.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46173/#review128789
---




src/hook/manager.hpp (lines 69 - 70)


Is this all the information the hook will need? Can it easily get from a 
containerId to a task/executorId and Info?



src/slave/containerizer/docker.cpp (lines 1078 - 1082)


Are you confident that we want this hook to run before persistent volumes 
are mounted?
Maybe what we really want is a slavePreLaunchExecutorContainerHook? Or 
maybe we'll have to have both in the future?


- Adam B


On April 13, 2016, 3:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46173/
> ---
> 
> (Updated April 13, 2016, 3:30 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5209
> https://issues.apache.org/jira/browse/MESOS-5209
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a slave post fetch hook.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 87e01a9dccb04bfdd5395867a45c46574815731b 
>   src/hook/manager.hpp 3af28a76493a95a3427fecb3a23dd80ecb84dfe9 
>   src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
>   src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 
> 
> Diff: https://reviews.apache.org/r/46173/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 46173: Added a slave post fetch hook.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46173/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-5209
https://issues.apache.org/jira/browse/MESOS-5209


Repository: mesos


Description
---

Added a slave post fetch hook.


Diffs
-

  include/mesos/hook.hpp 87e01a9dccb04bfdd5395867a45c46574815731b 
  src/hook/manager.hpp 3af28a76493a95a3427fecb3a23dd80ecb84dfe9 
  src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
  src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be 
  src/slave/containerizer/mesos/containerizer.cpp 
c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 

Diff: https://reviews.apache.org/r/46173/diff/


Testing
---

make check


Thanks,

Jie Yu