Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review129824
---


Ship it!




Thanks Guangya. It looks to me overall. I did a few small tweaks. Please take a 
look at the final patch.

- Jie Yu


On April 20, 2016, 10:14 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated April 20, 2016, 10:14 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 0ad473dc3bd45e122fba55a670e1a893e61c977a 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

(Updated 四月 20, 2016, 10:14 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
0ad473dc3bd45e122fba55a670e1a893e61c977a 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

(Updated 四月 15, 2016, 3:27 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
0ad473dc3bd45e122fba55a670e1a893e61c977a 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu 


> On 四月 14, 2016, 6:33 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 
> > 72-73
> > 
> >
> > How about moving "' used by volume isolator" to the second line?

I was now using `os::which`, so no need for this now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review128942
---


On 四月 14, 2016, 1:40 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated 四月 14, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review129023
---




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 59 - 
74)


we should add a os::which to check if dvdcli is in PATH or not.


- Jie Yu


On April 14, 2016, 1:40 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated April 14, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review128942
---




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 72 - 
73)


How about moving "' used by volume isolator" to the second line?


- Gilbert Song


On April 14, 2016, 6:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated April 14, 2016, 6:40 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

(Updated 四月 14, 2016, 1:40 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

(Updated 四月 14, 2016, 6:06 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review128819
---



Patch looks great!

Reviews applied: [45214, 45217, 45270, 45360, 45373, 46180]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 13, 2016, 11:41 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated April 13, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 46180: Implemented create() for docker volume isolator.

2016-04-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu