Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review167325
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On June 21, 2016, 6:11 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated June 21, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 08cd9a0383bcfe2814388d7d9b1feae812b112da 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> aaa0efe63e587b9e604082b52a3cb8c11545fbb9 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 48a05059969e068a0ee0d38b61be9e7104e3188d 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 249acad49122d988e44744384bcf840b941c0997 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> 
> Diff: https://reviews.apache.org/r/46182/diff/3/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-06-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review138957
---



Bad patch!

Reviews applied: [46182]

Failed command: ./support/apply-review.sh -n -r 46182

Error:
2016-06-21 22:35:28 URL:https://reviews.apache.org/r/46182/diff/raw/ 
[5264/5264] -> "46182.patch" [1]
error: patch failed: include/mesos/slave/isolator.proto:88
error: include/mesos/slave/isolator.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13928/console

- Mesos ReviewBot


On June 21, 2016, 6:11 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated June 21, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 08cd9a0383bcfe2814388d7d9b1feae812b112da 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> aaa0efe63e587b9e604082b52a3cb8c11545fbb9 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 48a05059969e068a0ee0d38b61be9e7104e3188d 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 249acad49122d988e44744384bcf840b941c0997 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-06-21 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review138868
---



Seems like this patch is included in https://reviews.apache.org/r/46498/

Could you discard it if it is not reviewable? Thanks!

- Gilbert Song


On May 13, 2016, 12:52 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated May 13, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-05-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review133221
---



Patch looks great!

Reviews applied: [46182]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 13, 2016, 7:52 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated May 13, 2016, 7:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-05-13 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/
---

(Updated May 13, 2016, 7:52 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Adding app runtime processing to appc store and provisioner.


Diffs (updated)
-

  include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
  src/slave/containerizer/mesos/provisioner/store.hpp 
1d477ef13ddd24fd8badae0decaa4a2271ecc746 

Diff: https://reviews.apache.org/r/46182/diff/


Testing
---

make check on linux passes 
AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest


Thanks,

Srinivas Brahmaroutu

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-21 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review129922
---




include/mesos/appc/spec.proto (line 62)


Todo comment style is `TODO(name): `. Also we end comments with 
period.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 199)


Why this variable?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 202)


indentation.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 203)


recommend better name for the variable `manifest1`



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 213)


This could return the default contructed ImageManifest object if none of 
the images's manifest could be found.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 307)


Fix indentation



src/slave/containerizer/mesos/provisioner/store.hpp (line 26)


headers should be alphabetically sorted.


- Jojy Varghese


On April 15, 2016, 6:23 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated April 15, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review129178
---



Patch looks great!

Reviews applied: [46182]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 6:23 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated April 15, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-15 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/
---

Review request for mesos.


Repository: mesos


Description
---

Adding app runtime processing to appc store and provisioner.


Diffs
-

  include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
  src/slave/containerizer/mesos/provisioner/store.hpp 
1d477ef13ddd24fd8badae0decaa4a2271ecc746 

Diff: https://reviews.apache.org/r/46182/diff/


Testing
---

make check on linux passes 
AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest


Thanks,

Srinivas Brahmaroutu