Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-07-07 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review141162
---




include/mesos/mesos.proto (line 1746)


`s/INVALID/UNKNOWN/`

The canonical name we add to proto enums to support upgrades seems to be 
`UNKNOWN`.



include/mesos/v1/mesos.proto (line 1740)


Proto enums should always start with an `UNKNOWN = 0` field to in order to 
support updates.


- Benjamin Bannier


On May 19, 2016, 7:06 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated May 19, 2016, 7:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review133858
---


Fix it, then Ship it!





include/mesos/mesos.proto (line 1734)


Remove the extra space before the text.



include/mesos/mesos.proto (line 1739)


Could you please add a NOTE here about why we want to start the tag number 
from 1000? Also, can you add an INVALID=0?


- Jie Yu


On May 11, 2016, 4:27 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated May 11, 2016, 4:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-10 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/
---

(Updated May 11, 2016, 4:27 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Bugs: MESOS-5232
https://issues.apache.org/jira/browse/MESOS-5232


Repository: mesos


Description
---

Added capabilities support in ContanerInfo protobuf.


Diffs (updated)
-

  include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
  include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 

Diff: https://reviews.apache.org/r/46369/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-06 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review132086
---




include/mesos/mesos.proto (line 1737)


I would call it `LinuxInfo` instead.

ProcessConfig sounds weird to me, even in the OCI spec. I understand things 
like capability, rlimit are process specific, but the only process we have 
control is the init process (i.e., the executor process in our case). I would 
rather simply that. All configurations are container level, if things like 
rlimit, capability are process specific, it'll be applied to the init process.



include/mesos/mesos.proto (line 1739)


Can you move this to the top level (i.e., not nested in LinuxInfo).



include/mesos/mesos.proto (line 1741)


Having an enum value being 0 is bad. See BenM's email about enumeration 
type semantics in protobuf. Basically, an unknown enum value will be mapped to 
0. For instance, if in the future, linux adds a new capability. If we simply 
extend this list, the old master/agent (using the old protobuf) will map that 
to 0 (CHOWN), which is not expected.

I understand that you want the value to be the same as that defined in 
`linux/capability.h`. But I don't think that's strictly necessary, right? I 
would suggest that you start the first enum at `1000` (i.e., `CHOWN = 1000`) so 
that you still have a systematic way to do the conversion. Also, we should set 
`UNKNOWN = 0`.


- Jie Yu


On May 6, 2016, 5:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated May 6, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/
---

(Updated May 6, 2016, 5:02 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5232
https://issues.apache.org/jira/browse/MESOS-5232


Repository: mesos


Description
---

Added capabilities support in ContanerInfo protobuf.


Diffs (updated)
-

  include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
  include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 

Diff: https://reviews.apache.org/r/46369/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-04-21 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/
---

(Updated April 21, 2016, 4:58 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5232
https://issues.apache.org/jira/browse/MESOS-5232


Repository: mesos


Description
---

Added capabilities support in ContanerInfo protobuf.


Diffs (updated)
-

  include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
  include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 

Diff: https://reviews.apache.org/r/46369/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-04-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review129494
---



Patch looks great!

Reviews applied: [46369]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 19, 2016, 6:28 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated April 19, 2016, 6:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-04-19 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5232
https://issues.apache.org/jira/browse/MESOS-5232


Repository: mesos


Description
---

Added capabilities support in ContanerInfo protobuf.


Diffs
-

  include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 

Diff: https://reviews.apache.org/r/46369/diff/


Testing
---

make check.


Thanks,

Jojy Varghese