Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review132906 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On May 12, 2016, 6:04 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46392/ > --- > > (Updated May 12, 2016, 6:04 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > This commit introduces temporary versions of 2 important functions: > `os::nonblock` and `os::cloexec`. We put them here in a placeholder > commit so that reviewers can make progress on subprocess. In the > immediate term, the plan is to figure out on a callsite-by-callsite > basis how to work around the functionality of `os::cloexec`. When we > collect more data, we will be in a better position to offer a way > forward here. > > > Diffs > - > > 3rdparty/stout/include/stout/os.hpp > 25e93200cf8b95f57931771073f3b6e34fff061b > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > 14734317d7fb40053ee808745ac3ba8c706a7669 > > Diff: https://reviews.apache.org/r/46392/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated May 12, 2016, 6:04 a.m.) Review request for mesos. Repository: mesos Description --- This commit introduces temporary versions of 2 important functions: `os::nonblock` and `os::cloexec`. We put them here in a placeholder commit so that reviewers can make progress on subprocess. In the immediate term, the plan is to figure out on a callsite-by-callsite basis how to work around the functionality of `os::cloexec`. When we collect more data, we will be in a better position to offer a way forward here. Diffs (updated) - 3rdparty/stout/include/stout/os.hpp 25e93200cf8b95f57931771073f3b6e34fff061b 3rdparty/stout/include/stout/os/windows/fcntl.hpp 14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review130278 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On April 23, 2016, 10:28 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46392/ > --- > > (Updated April 23, 2016, 10:28 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > This commit introduces temporary versions of 2 important functions: > `os::nonblock` and `os::cloexec`. We put them here in a placeholder > commit so that reviewers can make progress on subprocess. In the > immediate term, the plan is to figure out on a callsite-by-callsite > basis how to work around the functionality of `os::cloexec`. When we > collect more data, we will be in a better position to offer a way > forward here. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp > 14734317d7fb40053ee808745ac3ba8c706a7669 > > Diff: https://reviews.apache.org/r/46392/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated April 23, 2016, 10:28 p.m.) Review request for mesos. Repository: mesos Description --- This commit introduces temporary versions of 2 important functions: `os::nonblock` and `os::cloexec`. We put them here in a placeholder commit so that reviewers can make progress on subprocess. In the immediate term, the plan is to figure out on a callsite-by-callsite basis how to work around the functionality of `os::cloexec`. When we collect more data, we will be in a better position to offer a way forward here. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review129632 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On April 19, 2016, 4:35 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46392/ > --- > > (Updated April 19, 2016, 4:35 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > This commit introduces temporary versions of 2 important functions: > `os::nonblock` and `os::cloexec`. We put them here in a placeholder > commit so that reviewers can make progress on subprocess. In the > immediate term, the plan is to figure out on a callsite-by-callsite > basis how to work around the functionality of `os::cloexec`. When we > collect more data, we will be in a better position to offer a way > forward here. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp > 14734317d7fb40053ee808745ac3ba8c706a7669 > > Diff: https://reviews.apache.org/r/46392/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
