Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-10 Thread Alexander Rukletsov
> On May 5, 2016, 6:08 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 285-290 > > > > > > No need for the note here. Can you also move this down into the > > conditional that gates it below? > > >

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 10, 2016, 2:15 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-10 Thread Alexander Rukletsov
> On May 5, 2016, 6:08 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 292-294 > > > > > > This is confusing to me, it just means a retry as far as this patch is > > concerned. Can you remove this TODO?

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 10, 2016, 1:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review132323 --- Ship it! Modulo comments. - Ben Mahler On May 7, 2016, 1:02

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review132305 --- src/docker/executor.cpp (lines 396 - 397)

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-09 Thread haosdent huang
> On May 7, 2016, 1:22 p.m., haosdent huang wrote: > > src/docker/executor.cpp, line 398 > > > > > > Should it change to `if (killed || terminated ||..)`? > > Alexander Rukletsov wrote: > Currently, if

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-09 Thread Alexander Rukletsov
> On May 7, 2016, 1:22 p.m., haosdent huang wrote: > > src/docker/executor.cpp, line 398 > > > > > > Should it change to `if (killed || terminated ||..)`? Currently, if `terminated == true` then `killed == true` as

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review132136 --- src/docker/executor.cpp (line 398)

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 7, 2016, 1:02 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-07 Thread Alexander Rukletsov
> On May 5, 2016, 6:08 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 285-290 > > > > > > No need for the note here. Can you also move this down into the > > conditional that gates it below? > > >

Re: Review Request 46491: Ensured subsequent kills are ignored after the task is reaped.

2016-05-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 7, 2016, 12:50 p.m.) Review request for mesos, Benjamin Bannier