Re: Review Request 46687: Updated `dispatch` calls to use lambda in http_tests.cpp.
> On June 26, 2016, 7:37 a.m., Michael Park wrote: > > Could you specify that this only updates `http_tests.cpp`? There are other > > places in the codebase where we explicitly construct a `std::function` > > first, but we don't update all of those in this patch. > > Michael Park wrote: > Just in the summary and/or description, that is. Hi, @mcypark Thanks a lot for your detail comments. I found the remain legacy codes are only exists in `deferred.hpp`. I post a sperate patch in https://reviews.apache.org/r/49315/ - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/#review139483 --- On June 28, 2016, 9:43 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46687/ > --- > > (Updated June 28, 2016, 9:43 a.m.) > > > Review request for mesos, Kevin Klues and Michael Park. > > > Bugs: MESOS-4611 > https://issues.apache.org/jira/browse/MESOS-4611 > > > Repository: mesos > > > Description > --- > > Updated `dispatch` calls to use lambda in http_tests.cpp. > > > Diffs > - > > 3rdparty/libprocess/src/tests/http_tests.cpp > 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a > > Diff: https://reviews.apache.org/r/46687/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 46687: Updated `dispatch` calls to use lambda in http_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/#review139820 --- Patch looks great! Reviews applied: [46686, 46687] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 28, 2016, 9:43 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46687/ > --- > > (Updated June 28, 2016, 9:43 a.m.) > > > Review request for mesos, Kevin Klues and Michael Park. > > > Bugs: MESOS-4611 > https://issues.apache.org/jira/browse/MESOS-4611 > > > Repository: mesos > > > Description > --- > > Updated `dispatch` calls to use lambda in http_tests.cpp. > > > Diffs > - > > 3rdparty/libprocess/src/tests/http_tests.cpp > 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a > > Diff: https://reviews.apache.org/r/46687/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 46687: Updated `dispatch` calls to use lambda in http_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/ --- (Updated June 28, 2016, 9:43 a.m.) Review request for mesos, Kevin Klues and Michael Park. Changes --- Address @mcypark's comments. Summary (updated) - Updated `dispatch` calls to use lambda in http_tests.cpp. Bugs: MESOS-4611 https://issues.apache.org/jira/browse/MESOS-4611 Repository: mesos Description (updated) --- Updated `dispatch` calls to use lambda in http_tests.cpp. Diffs (updated) - 3rdparty/libprocess/src/tests/http_tests.cpp 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a Diff: https://reviews.apache.org/r/46687/diff/ Testing --- Thanks, haosdent huang
