Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/#review132273 --- Ship it! I'll slightly change the wording and commit that for y

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/ --- (Updated May 9, 2016, 11:34 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/ --- (Updated May 9, 2016, 11:04 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-09 Thread Benjamin Bannier
> On May 4, 2016, 10:34 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, lines 623-624 > > > > > > How about something like: "The principal should be authorized to query > > this endpoint"? > > Neil Conway

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-09 Thread Alexander Rukletsov
> On May 4, 2016, 8:34 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, lines 623-624 > > > > > > How about something like: "The principal should be authorized to query > > this endpoint"? > > Neil Conway w

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-05 Thread Neil Conway
> On May 4, 2016, 8:34 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, lines 623-624 > > > > > > How about something like: "The principal should be authorized to query > > this endpoint"? +1, although I'd

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/#review131738 --- Please run the script and include the .md change into this patch.

Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil Conway.