Re: Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

2016-05-05 Thread Anand Mazumdar
> On May 5, 2016, 11:57 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 5974-5977 > > > > > > Can we just copy the keys here instead of the entire maps? > > > > ``` > > foreach (const Framewo

Re: Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

2016-05-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46960/#review131970 --- Fix it, then Ship it! src/master/master.cpp (lines 5973 - 5976

Re: Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46960/#review131630 --- Patch looks great! Reviews applied: [46960] Passed command: expo

Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

2016-05-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46960/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --