Re: Review Request 47090: Removed side-effects from MetricsTest.SnapshotAuthenticationEnabled.

2016-05-07 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47090/#review132160
---



Patch looks great!

Reviews applied: [47090]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 7, 2016, 11:06 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47090/
> ---
> 
> (Updated May 7, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test was previously adding metrics without removing them, which
> meant that the test fails when run in repetition. Since this test
> only cares about authentication, we can simply remove the metrics
> from the test entirely.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 1cda7b4ec31fcd06161925ce5788741f299217c7 
> 
> Diff: https://reviews.apache.org/r/47090/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Review Request 47090: Removed side-effects from MetricsTest.SnapshotAuthenticationEnabled.

2016-05-07 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47090/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

The test was previously adding metrics without removing them, which
meant that the test fails when run in repetition. Since this test
only cares about authentication, we can simply remove the metrics
from the test entirely.


Diffs
-

  3rdparty/libprocess/src/tests/metrics_tests.cpp 
1cda7b4ec31fcd06161925ce5788741f299217c7 

Diff: https://reviews.apache.org/r/47090/diff/


Testing
---

Ran in repetition.


Thanks,

Ben Mahler