Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review134512 --- Patch looks great! Reviews applied: [47374] Passed command:

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 23, 2016, 7:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
> On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1937-1938 > > > > > > Why does libmesos_tests_la_SOURCES need to include qos_controllers code? I don't remember the exact reason, but one of

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 23, 2016, 7 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review134476 --- Looks ok to me, but I'd love for @jieyu or @karya or @tillt to

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review133438 --- Patch looks great! Reviews applied: [47374] Passed command:

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 16, 2016, 1:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 16, 2016, 11:10 a.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review133249 --- Bad patch! Reviews applied: [47374, 47216, 47150, 47215, 47214,