Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134278
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2016, 12:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 22, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134270
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 12:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 22, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 22, 2016, 12:52 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @klueska's comments.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md


Thanks,

haosdent huang

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-22 Thread haosdent huang 


> On May 20, 2016, 6:45 p.m., Kevin Klues wrote:
> > docs/release-guide.md, line 180
> > 
> >
> > This isn't really a step in "updating the website".  As such, I'd 
> > probably move this to the last step and reword it slightly.
> > 
> > ```
> > 5. Write a blog post announcing the new release and its features and 
> > major bug fixes. Include a link to the updated website.
> > ```

Thanks a lot for your helpful review comments! Just updated, may you review it 
again? Thank you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134184
---


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134184
---




docs/release-guide.md (line 180)


This isn't really a step in "updating the website".  As such, I'd probably 
move this to the last step and reword it slightly.

```
5. Write a blog post announcing the new release and its features and major 
bug fixes. Include a link to the updated website.
```


- Kevin Klues


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134177
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang 


> On May 20, 2016, 5:01 p.m., Kevin Klues wrote:
> > docs/release-guide.md, line 190
> > 
> >
> > s/Noted/Note
> > 
> > s/when build it/
> > s/when building it/
> > 
> > Is it obvious how to do this from the README?

Thank you very much for your reviews.

>Is it obvious how to do this from the README?

Yes, `site/README.md` include the instructions.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134161
---


On May 20, 2016, 5:29 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 20, 2016, 5:29 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @klueska's comments


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134161
---




docs/release-guide.md (line 182)


s/releases/release

s/in/on/



docs/release-guide.md (line 186)


s/for the details/for details/



docs/release-guide.md (line 187)


s/Noted/Note

s/when build it/
s/when building it/

Is it obvious how to do this from the README?



docs/release-guide.md (line 189)


s/Check/Check out/

s/update it by/update it with/

s/our new version website pages/the new version of the the website/


- Kevin Klues


On May 20, 2016, 3:34 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134159
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 3:34 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 20, 2016, 3:34 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang

Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang