Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134805 --- Ship it! Ship It! - Vinod Kone On May 23, 2016, 9:08 p.m.,

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 1:03 a.m., haosdent huang wrote: > > Do you forget to update > > * `framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24 > > * `agent.html` > >

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134458 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- (Updated May 23, 2016, 9:08 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Deshna Jain
> On May 23, 2016, 1:03 a.m., haosdent huang wrote: > > Do you forget to update > > * `framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24 > > * `agent.html` > >

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134297 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134296 --- Do you forget to update * `framework.html`

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- (Updated May 23, 2016, 12:33 a.m.) Review request for mesos, haosdent huang

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134286 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134285 --- src/webui/master/static/frameworks.html (line 16)

Review Request 47702: Added framework role & principal to the Web UI.

2016-05-22 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- Review request for mesos, haosdent huang and Vinod Kone. Bugs: MESOS-4788