Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135455 --- Ship it! Ship It! - Anand Mazumdar On May 29, 2016, 9:38

Re: Review Request 48008: Added v1 protos for master and agent APIs.

> On May 29, 2016, 7:12 p.m., Anand Mazumdar wrote: > > include/mesos/v1/master.proto, line 59 > > > > > > s/streaming// > > > > hmm.. I find it a bit odd to include the business logic of the > >

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 9:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135430 --- Looks very good. The only small concern being around ordering

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 6:56 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 1:17 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48008: Added v1 protos for master and agent APIs.

> On May 28, 2016, 10:58 p.m., Kevin Klues wrote: > > include/mesos/v1/agent.hpp, lines 35-36 > > > > > > Why is this wrapped and the one aboove not? They are the same line > > length it's not of the same length!

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135398 --- include/mesos/v1/agent.hpp (lines 35 - 36)

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 28, 2016, 8:29 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.