Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135674 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 6:32 a.m., A

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135613 --- Patch looks great! Reviews applied: [48049] Passed command: expo

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
> On May 31, 2016, 12:06 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1205 > > > > > > I think we are trying to get leading master here, so should we return > > `master->leader.get()`? > > Anand Mazumdar

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- (Updated May 31, 2016, 6:32 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
> On May 31, 2016, 12:06 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1205 > > > > > > I think we are trying to get leading master here, so should we return > > `master->leader.get()`? We won't ever reach

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135563 --- src/master/http.cpp (line 1205)

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135550 --- Fix it, then Ship it! src/master/http.cpp (lines 1203 - 1205)

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135544 --- Patch looks great! Reviews applied: [48049] Passed command: expo

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- (Updated May 30, 2016, 9:01 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135541 --- src/internal/evolve.hpp (line 118)

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- (Updated May 30, 2016, 7:56 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
> On May 30, 2016, 6:54 p.m., Anand Mazumdar wrote: > > src/internal/evolve.hpp, lines 118-119 > > > > > > This is not quite what I meant. My bad if my initial comment wasn't > > clear: > > > > I wanted an

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135535 --- src/internal/evolve.hpp (lines 118 - 119)

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- (Updated May 30, 2016, 6:44 p.m.) Review request for mesos and Vinod Kone. Bu

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135525 --- LGTM, just one minor issue where we could benefit from implementin

Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5497 https://issues.ap