Re: Review Request 48264: Added test for optional request.object field.

2016-06-27 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review139569
---




src/tests/authorization_tests.cpp (line 2108)


/usecase/use case/



src/tests/authorization_tests.cpp (line 2111)


Wrong indentation.



src/tests/authorization_tests.cpp (line 2115)


/tardown/teardown/


- Alexander Rojas


On June 6, 2016, 5:11 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> ---
> 
> (Updated June 6, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48264: Added test for optional request.object field.

2016-06-07 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136426
---


Ship it!




Ship It!

- Till Toenshoff


On June 6, 2016, 3:11 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> ---
> 
> (Updated June 6, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48264: Added test for optional request.object field.

2016-06-06 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/
---

(Updated June 6, 2016, 3:11 p.m.)


Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.


Changes
---

Addressed review.


Bugs: MESOS-5405
https://issues.apache.org/jira/browse/MESOS-5405


Repository: mesos


Description
---

As MESOS-5405 changes the request.object
field to optional. We need to check that it only
matches an `ANY` ACL.


Diffs (updated)
-

  src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 

Diff: https://reviews.apache.org/r/48264/diff/


Testing
---

make check (OSX) + repeat new test 100 times


Thanks,

Joerg Schad

Re: Review Request 48264: Added test for optional request.object field.

2016-06-06 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136259
---




src/tests/authorization_tests.cpp (line 2106)


what do you mean by "is only allowed for `ANY`"?

did you mean "matches an ACL whose Object is `ANY`" ?



src/tests/authorization_tests.cpp (line 2121)


s/principle/principal/


- Vinod Kone


On June 6, 2016, 8:19 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> ---
> 
> (Updated June 6, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48264: Added test for optional request.object field.

2016-06-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136229
---



Patch looks great!

Reviews applied: [48264]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 6, 2016, 8:19 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> ---
> 
> (Updated June 6, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 48264: Added test for optional request.object field.

2016-06-06 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/
---

Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.


Bugs: MESOS-5405
https://issues.apache.org/jira/browse/MESOS-5405


Repository: mesos


Description
---

As MESOS-5405 changes the request.object
field to optional. We need to check that it only
matches an `ANY` ACL.


Diffs
-

  src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 

Diff: https://reviews.apache.org/r/48264/diff/


Testing
---

make check (OSX) + repeat new test 100 times


Thanks,

Joerg Schad