Re: Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

> On June 15, 2016, 8:54 p.m., Vinod Kone wrote:
> > Ship It!
> 
> Vinod Kone wrote:
> see the comment in the previous review about the path of the proto file.

Post the patch at https://reviews.apache.org/r/48800/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137837
---


On June 16, 2016, 5:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> ---
> 
> (Updated June 16, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.hpp PRE-CREATION 
>   include/mesos/agent/agent.proto PRE-CREATION 
>   src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/
---

(Updated June 16, 2016, 5:13 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5593
https://issues.apache.org/jira/browse/MESOS-5593


Repository: mesos


Description
---

Added unversioned protos for agent API.


Diffs (updated)
-

  include/mesos/agent/agent.hpp PRE-CREATION 
  include/mesos/agent/agent.proto PRE-CREATION 
  src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 

Diff: https://reviews.apache.org/r/48587/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/
---

(Updated June 15, 2016, 2:27 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.


Changes
---

Rebase and address @vinodkone @anandazumdar comments.


Bugs: MESOS-5593
https://issues.apache.org/jira/browse/MESOS-5593


Repository: mesos


Description
---

Added unversioned protos for agent API.


Diffs (updated)
-

  include/mesos/agent/agent.hpp PRE-CREATION 
  include/mesos/agent/agent.proto PRE-CREATION 
  src/Makefile.am f672fc9d2b58e785c65e21a4e52c60c04ce2498a 

Diff: https://reviews.apache.org/r/48587/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

> On June 13, 2016, 8:18 p.m., Anand Mazumdar wrote:
> > Can we name the unversioned proto file as just `agent.proto`? It would be 
> > good to not introduce the `Slave` terminology going forward :-)
> 
> Vinod Kone wrote:
> also the package name, class name, namespace etc.

Awesome! Let me rename.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137370
---


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/slave.hpp PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48587: Added unversioned protos for agent API.

[Vinod Kone]

> On June 13, 2016, 8:18 p.m., Anand Mazumdar wrote:
> > Can we name the unversioned proto file as just `agent.proto`? It would be 
> > good to not introduce the `Slave` terminology going forward :-)

also the package name, class name, namespace etc.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137370
---


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/slave.hpp PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48587: Added unversioned protos for agent API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137370
---



Can we name the unversioned proto file as just `agent.proto`? It would be good 
to not introduce the `Slave` terminology going forward :-)


src/Makefile.am (line 1229)


Nit: Alignment of ``.


- Anand Mazumdar


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/slave.hpp PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/
---

(Updated June 12, 2016, 6:01 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5593
https://issues.apache.org/jira/browse/MESOS-5593


Repository: mesos


Description
---

Added unversioned protos for agent API.


Diffs (updated)
-

  include/mesos/slave/slave.hpp PRE-CREATION 
  include/mesos/slave/slave.proto PRE-CREATION 
  src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 

Diff: https://reviews.apache.org/r/48587/diff/


Testing
---


Thanks,

haosdent huang

Review Request 48587: Added unversioned protos for agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/
---

Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.


Bugs: MESOS-5593
https://issues.apache.org/jira/browse/MESOS-5593


Repository: mesos


Description
---

Added unversioned protos for agent API.


Diffs
-

  include/mesos/slave/slave.hpp PRE-CREATION 
  include/mesos/slave/slave.proto PRE-CREATION 
  src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 

Diff: https://reviews.apache.org/r/48587/diff/


Testing
---


Thanks,

haosdent huang