Re: Review Request 48684: Revised documentation for task reconciliation.

2016-06-16 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48684/#review138126
---


Ship it!




Ship It!

- Till Toenshoff


On June 14, 2016, 12:03 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48684/
> ---
> 
> (Updated June 14, 2016, 12:03 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In particular, add a note that the `TaskStatus` messages
> produced by reconciliation can be identified by looking at
> the `reason` field, and that these messages won't have
> other fields like `labels` and `data` set. Also, add
> recommendations for the how to do reconciliation and edit
> some of the previous text for tone and brevity.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 2605f68c983403d4fe0cbb5d76b31a9244681d43 
>   docs/reconciliation.md ce8435587e93e8e07dc9b0637fad7f900fbe65bb 
> 
> Diff: https://reviews.apache.org/r/48684/diff/
> 
> 
> Testing
> ---
> 
> previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 48684: Revised documentation for task reconciliation.

2016-06-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48684/#review137510
---



Patch looks great!

Reviews applied: [48684]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 14, 2016, 12:03 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48684/
> ---
> 
> (Updated June 14, 2016, 12:03 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In particular, add a note that the `TaskStatus` messages
> produced by reconciliation can be identified by looking at
> the `reason` field, and that these messages won't have
> other fields like `labels` and `data` set. Also, add
> recommendations for the how to do reconciliation and edit
> some of the previous text for tone and brevity.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 2605f68c983403d4fe0cbb5d76b31a9244681d43 
>   docs/reconciliation.md ce8435587e93e8e07dc9b0637fad7f900fbe65bb 
> 
> Diff: https://reviews.apache.org/r/48684/diff/
> 
> 
> Testing
> ---
> 
> previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Review Request 48684: Revised documentation for task reconciliation.

2016-06-14 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48684/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

In particular, add a note that the `TaskStatus` messages
produced by reconciliation can be identified by looking at
the `reason` field, and that these messages won't have
other fields like `labels` and `data` set. Also, add
recommendations for the how to do reconciliation and edit
some of the previous text for tone and brevity.


Diffs
-

  docs/high-availability-framework-guide.md 
2605f68c983403d4fe0cbb5d76b31a9244681d43 
  docs/reconciliation.md ce8435587e93e8e07dc9b0637fad7f900fbe65bb 

Diff: https://reviews.apache.org/r/48684/diff/


Testing
---

previewed in site-docker.


Thanks,

Neil Conway