Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

2016-06-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/#review137978
---



Patch looks great!

Reviews applied: [48687]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 1:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48687/
> ---
> 
> (Updated June 16, 2016, 1:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5611
> https://issues.apache.org/jira/browse/MESOS-5611
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced log message if the absolute path does not exist.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 8cebfebbd9bf3f616f3cd305889f3372aca5e3f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 35213ce8f9d0e81fdd2da15c7a2cee1c779f3555 
> 
> Diff: https://reviews.apache.org/r/48687/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050 --command="sleep 10" --name=test 
> --volumes=/root/test/volume4.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to 
> read a command line option out of without using 'file:// is deprecated and 
> will be removed in a future release. Simply adding 'file://' to the beginning 
> of the path should eliminate this warning.
> I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
> I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at 
> master@192.168.56.12:5050
> Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-'
> Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
> Received status update TASK_FAILED for task 'test'
>   message: 'Failed to launch container: Absolute container path '/tmp/abc' 
> does not exist; Container destroyed while preparing isolators'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

2016-06-15 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/
---

(Updated 六月 16, 2016, 1:51 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed Gilbert's comments


Bugs: MESOS-5611
https://issues.apache.org/jira/browse/MESOS-5611


Repository: mesos


Description
---

Enhanced log message if the absolute path does not exist.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
8cebfebbd9bf3f616f3cd305889f3372aca5e3f3 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
35213ce8f9d0e81fdd2da15c7a2cee1c779f3555 

Diff: https://reviews.apache.org/r/48687/diff/


Testing
---

make
make check

root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050 --command="sleep 10" --name=test 
--volumes=/root/test/volume4.json
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to 
read a command line option out of without using 'file:// is deprecated and will 
be removed in a future release. Simply adding 'file://' to the beginning of the 
path should eliminate this warning.
I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at 
master@192.168.56.12:5050
Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-'
Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
Received status update TASK_FAILED for task 'test'
  message: 'Failed to launch container: Absolute container path '/tmp/abc' does 
not exist; Container destroyed while preparing isolators'


Thanks,

Guangya Liu

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

2016-06-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/#review137888
---


Fix it, then Ship it!




Could you this nit in `recover()` and `_recover()` in 
docker/volume/isolator.cpp as well.


src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 360 - 
361)


just some nits:

would you mind having the space to upper line?
e.g.,

```
  return Failure("Absolute container path '" + target + "' "
 "does not exist");```



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 418)


ditto.


- Gilbert Song


On June 14, 2016, 5:34 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48687/
> ---
> 
> (Updated June 14, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5611
> https://issues.apache.org/jira/browse/MESOS-5611
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced log message if the absolute path does not exist.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 8cebfebbd9bf3f616f3cd305889f3372aca5e3f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 35213ce8f9d0e81fdd2da15c7a2cee1c779f3555 
> 
> Diff: https://reviews.apache.org/r/48687/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050 --command="sleep 10" --name=test 
> --volumes=/root/test/volume4.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to 
> read a command line option out of without using 'file:// is deprecated and 
> will be removed in a future release. Simply adding 'file://' to the beginning 
> of the path should eliminate this warning.
> I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
> I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at 
> master@192.168.56.12:5050
> Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-'
> Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
> Received status update TASK_FAILED for task 'test'
>   message: 'Failed to launch container: Absolute container path '/tmp/abc' 
> does not exist; Container destroyed while preparing isolators'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

2016-06-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/#review137549
---



Patch looks great!

Reviews applied: [48687]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 14, 2016, 12:34 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48687/
> ---
> 
> (Updated June 14, 2016, 12:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5611
> https://issues.apache.org/jira/browse/MESOS-5611
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced log message if the absolute path does not exist.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 8cebfebbd9bf3f616f3cd305889f3372aca5e3f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 35213ce8f9d0e81fdd2da15c7a2cee1c779f3555 
> 
> Diff: https://reviews.apache.org/r/48687/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050 --command="sleep 10" --name=test 
> --volumes=/root/test/volume4.json
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to 
> read a command line option out of without using 'file:// is deprecated and 
> will be removed in a future release. Simply adding 'file://' to the beginning 
> of the path should eliminate this warning.
> I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
> I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at 
> master@192.168.56.12:5050
> Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-'
> Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
> Received status update TASK_FAILED for task 'test'
>   message: 'Failed to launch container: Absolute container path '/tmp/abc' 
> does not exist; Container destroyed while preparing isolators'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 48687: Enhanced log message if the absolute path does not exist.

2016-06-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48687/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5611
https://issues.apache.org/jira/browse/MESOS-5611


Repository: mesos


Description
---

Enhanced log message if the absolute path does not exist.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
8cebfebbd9bf3f616f3cd305889f3372aca5e3f3 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
35213ce8f9d0e81fdd2da15c7a2cee1c779f3555 

Diff: https://reviews.apache.org/r/48687/diff/


Testing
---

make
make check

root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050 --command="sleep 10" --name=test 
--volumes=/root/test/volume4.json
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0614 09:21:25.100939 28209 parse.hpp:115] Specifying an absolute filename to 
read a command line option out of without using 'file:// is deprecated and will 
be removed in a future release. Simply adding 'file://' to the beginning of the 
path should eliminate this warning.
I0614 09:21:25.104532 28209 scheduler.cpp:187] Version: 1.0.0
I0614 09:21:25.106834 28231 scheduler.cpp:471] New master detected at 
master@192.168.56.12:5050
Subscribed with ID '57cda92a-b703-435a-94f0-28e88746f8b5-'
Submitted task 'test' to agent '57cda92a-b703-435a-94f0-28e88746f8b5-S0'
Received status update TASK_FAILED for task 'test'
  message: 'Failed to launch container: Absolute container path '/tmp/abc' does 
not exist; Container destroyed while preparing isolators'


Thanks,

Guangya Liu