Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review141385
---


Fix it, then Ship it!





src/tests/api_tests.cpp (lines 2561 - 2563)


Nit: Similar comment as the last review. It's a good practice to alias this 
variable since it's invoked multiple times for readability. I would make the 
change while committing.


- Anand Mazumdar


On July 9, 2016, 2:53 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated July 9, 2016, 2:53 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 362cf17da2655302472a0a7bcdf47898d3090f47 
>   src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
>   src/tests/api_tests.cpp fe26351c7712668e7c548be201ecae6ab006a0fa 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 9, 2016, 2:53 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

Used blocks to enclosure different tests


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 362cf17da2655302472a0a7bcdf47898d3090f47 
  src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
  src/tests/api_tests.cpp fe26351c7712668e7c548be201ecae6ab006a0fa 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 9, 2016, 12:36 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code according to Anand's comments


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 362cf17da2655302472a0a7bcdf47898d3090f47 
  src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
  src/tests/api_tests.cpp fe26351c7712668e7c548be201ecae6ab006a0fa 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review141358
---



Patch looks great!

Reviews applied: [49796, 49679, 49242, 49243, 49244, 49245]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 8, 2016, 11:51 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated July 8, 2016, 11:51 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
>   src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review141317
---




src/slave/http.cpp (line 85)


Kill this.



src/slave/http.cpp (line 1429)


Kill this



src/tests/api_tests.cpp (line 2510)


Similar comment to earlier review around adding a couple of more tests.


- Anand Mazumdar


On July 8, 2016, 11:51 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated July 8, 2016, 11:51 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
>   src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-08 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 8, 2016, 11:51 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

refined code per discussion with Anand


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
  src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-07 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 7, 2016, 11:42 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
  src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-07 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 7, 2016, 12:41 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

refined code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review140973
---



Bad patch!

Reviews applied: [49245, 49244, 49243, 49242, 49679, 49301]

Failed command: ./support/apply-review.sh -n -r 49242

Error:
2016-07-06 09:50:12 URL:https://reviews.apache.org/r/49242/diff/raw/ 
[5390/5390] -> "49242.patch" [1]
error: patch failed: include/mesos/master/master.proto:267
error: include/mesos/master/master.proto: patch does not apply
error: patch failed: include/mesos/v1/master/master.proto:268
error: include/mesos/v1/master/master.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14177/console

- Mesos ReviewBot


On July 6, 2016, 5:23 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated July 6, 2016, 5:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 67ed67e168faab692d59e077b2e9a927756c6704 
>   src/slave/slave.hpp 484ba758b4c87935aabd2f76a0e654a3c6d09167 
>   src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-07-05 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 6, 2016, 5:23 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

udpate code according to message changes


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 67ed67e168faab692d59e077b2e9a927756c6704 
  src/slave/slave.hpp 484ba758b4c87935aabd2f76a0e654a3c6d09167 
  src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review140161
---



Patch looks great!

Reviews applied: [49301, 49242, 49243, 49244, 49245]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 30, 2016, 7:01 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated June 30, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 
>   src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
>   src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-30 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 六月 30, 2016, 7:01 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

updated code due to protobuf message changes


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 
  src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
  src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review139956
---



Patch looks great!

Reviews applied: [49301, 49242, 49243, 49244, 49245]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 29, 2016, 2:06 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated June 29, 2016, 2:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 
>   src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
>   src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-28 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 六月 29, 2016, 2:06 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

rebase and update code chain dependency


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 44d8cc98c0c1ada9d5313a3fe5c66029c9c373c6 
  src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
  src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review139855
---



Patch looks great!

Reviews applied: [49242, 49301, 49243, 49244, 49245]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 28, 2016, 11:15 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated June 28, 2016, 11:15 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f325bc6b7c92adfb47c1a636b7d385a00e461afb 
>   src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
>   src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-28 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 六月 28, 2016, 11:15 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp f325bc6b7c92adfb47c1a636b7d385a00e461afb 
  src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 
  src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review139574
---



Patch looks great!

Reviews applied: [49242, 49243, 49244, 49245]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 27, 2016, 9:12 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated June 27, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 
>   src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review139572
---


Fix it, then Ship it!




Ship It!


src/slave/http.cpp (lines 1337 - 1347)


Indent 2 spaces here for case/default keyword.


- haosdent huang


On June 27, 2016, 9:12 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> ---
> 
> (Updated June 27, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
> https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 
>   src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread zhou xing 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs
-

  src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 
  src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing