Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Jie Yu
> On June 27, 2016, 11:41 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos-chroot.cpp, lines 107-110 > > > > > > Hum, that reminds me that there's a bug in the current command executor > > impl. Since pivot_roo

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Jie Yu
> On July 4, 2016, 5:06 p.m., Jie Yu wrote: > > Please see the test section of https://reviews.apache.org/r/49569/ > > > > Let me know if that's ok or not. Thanks! > > Ian Downes wrote: > Hey, thanks for looking at this. I looked at the review for > `mesos-containerizer launch` and it just

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
> On June 27, 2016, 4:41 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos-chroot.cpp, lines 107-110 > > > > > > Hum, that reminds me that there's a bug in the current command executor > > impl. Since pivot_root

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
> On July 4, 2016, 10:06 a.m., Jie Yu wrote: > > Please see the test section of https://reviews.apache.org/r/49569/ > > > > Let me know if that's ok or not. Thanks! > > Ian Downes wrote: > Hey, thanks for looking at this. I looked at the review for > `mesos-containerizer launch` and it jus

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
> On July 4, 2016, 10:06 a.m., Jie Yu wrote: > > Please see the test section of https://reviews.apache.org/r/49569/ > > > > Let me know if that's ok or not. Thanks! Hey, thanks for looking at this. I looked at the review for `mesos-containerizer launch` and it just optionally creates a new mou

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review140687 --- Please see the test section of https://reviews.apache.org/r/49569/

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review140076 --- I'll try to refactor `mesos-containerizer launch` so that command

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review139601 --- src/Makefile.am (line 1375)

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review139668 --- Bad patch! Reviews applied: [49273] Failed command: ./support/ap

Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/ --- Review request for mesos, Joshua Cohen and Jie Yu. Repository: mesos Descript