Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/#review141197
---




docs/configuration.md (lines 1516 - 1523)


This doesn't look like a complete sync of the flags, for example this one 
doesn't reflect what is in slave/flags.cpp:


https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99

How did you generate the update? I'd recommend running `--help` on both the 
master and slave binaries and updating based on that. We will add tooling in 
the future so that you could do this via a script.


- Benjamin Mahler


On July 7, 2016, 9:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49587/
> ---
> 
> (Updated July 7, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5758
> https://issues.apache.org/jira/browse/MESOS-5758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synced up flags in both master and agent to configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49587/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> https://github.com/gyliu513/mesos/blob/master/docs/configuration.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/#review141148
---



Patch looks great!

Reviews applied: [49587]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 9:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49587/
> ---
> 
> (Updated July 7, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5758
> https://issues.apache.org/jira/browse/MESOS-5758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synced up flags in both master and agent to configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49587/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> https://github.com/gyliu513/mesos/blob/master/docs/configuration.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/
---

(Updated 七月 7, 2016, 9:29 a.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-

Synced up flags in both master and agent to configuration.md.


Bugs: MESOS-5758
https://issues.apache.org/jira/browse/MESOS-5758


Repository: mesos


Description (updated)
---

Synced up flags in both master and agent to configuration.md.


Diffs (updated)
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49587/diff/


Testing
---

make
make check

https://github.com/gyliu513/mesos/blob/master/docs/configuration.md


Thanks,

Guangya Liu