Re: Review Request 49768: Updated configuration.md.

2016-07-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141218
---



Patch looks great!

Reviews applied: [49768]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

2016-07-07 Thread Vinod Kone 


> On July 7, 2016, 7:17 p.m., Benjamin Mahler wrote:
> > docs/configuration.md, lines 1571-1578
> > 
> >
> > This doesn't match the latest version in flags.cpp, how did you 
> > generate the update?
> > 
> > 
> > https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99

see my comment below.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141201
---


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

2016-07-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141206
---


Ship it!




I'll commit this as is and do another commit/review for the missed updates.

- Vinod Kone


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

2016-07-07 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141201
---




docs/configuration.md (lines 1508 - 1515)


This doesn't match the latest version in flags.cpp, how did you generate 
the update?


https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99


- Benjamin Mahler


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

2016-07-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/
---

(Updated July 7, 2016, 6:17 p.m.)


Review request for mesos, Jay Guo and Vinod Kone.


Repository: mesos


Description
---

Updated configuration.md.


Diffs (updated)
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49768/diff/


Testing (updated)
---

Preview at 
https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md


Thanks,

haosdent huang

Review Request 49768: Updated configuration.md.

2016-07-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated configuration.md.


Diffs
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49768/diff/


Testing
---


Thanks,

haosdent huang