Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review142107
---


Ship it!




Ship It!

- Vinod Kone


On July 12, 2016, 4:03 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 12, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review141869
---



Patch looks great!

Reviews applied: [49757, 49758, 49759, 49760, 49797, 49798, 49799, 49800]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 12, 2016, 4:03 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 12, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-11 Thread haosdent huang 


> On July 12, 2016, 12:20 a.m., Vinod Kone wrote:
> >
> 
> Vinod Kone wrote:
> also, can you rebase the chain?

Thanks a lot for your reviews, just updated.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review141812
---


On July 12, 2016, 4:03 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 12, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/
---

(Updated July 12, 2016, 4:03 a.m.)


Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Changes
---

Address @vinodkone's comment.


Bugs: MESOS-5516
https://issues.apache.org/jira/browse/MESOS-5516


Repository: mesos


Description
---

Added test case for 'GetState' call in v1 agent API.


Diffs (updated)
-

  src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 

Diff: https://reviews.apache.org/r/49800/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review141836
---



Bad patch!

Reviews applied: [49800, 49799, 49798, 49797, 49760, 49759, 49758, 49757]

Failed command: ./support/apply-review.sh -n -r 49757

Error:
2016-07-12 03:51:54 URL:https://reviews.apache.org/r/49757/diff/raw/ 
[7371/7371] -> "49757.patch" [1]
error: patch failed: include/mesos/agent/agent.proto:181
error: include/mesos/agent/agent.proto: patch does not apply
error: patch failed: include/mesos/v1/agent/agent.proto:181
error: include/mesos/v1/agent/agent.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14273/console

- Mesos ReviewBot


On July 8, 2016, 4:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 8, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-11 Thread Vinod Kone 


> On July 12, 2016, 12:20 a.m., Vinod Kone wrote:
> >

also, can you rebase the chain?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review141812
---


On July 8, 2016, 4:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 8, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/#review141812
---




src/tests/api_tests.cpp (line 2838)


need to do Clock::pause() and Clock::settle()


- Vinod Kone


On July 8, 2016, 4:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49800/
> ---
> 
> (Updated July 8, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5516
> https://issues.apache.org/jira/browse/MESOS-5516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/
---

(Updated July 8, 2016, 4:13 p.m.)


Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Changes
---

Update ticket field.


Bugs: MESOS-5516
https://issues.apache.org/jira/browse/MESOS-5516


Repository: mesos


Description
---

Added test case for 'GetState' call in v1 agent API.


Diffs
-

  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49800/diff/


Testing
---


Thanks,

haosdent huang

Review Request 49800: Added test case for 'GetState' call in v1 agent API.

2016-07-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49800/
---

Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Repository: mesos


Description
---

Added test case for 'GetState' call in v1 agent API.


Diffs
-

  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49800/diff/


Testing
---


Thanks,

haosdent huang