Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review142857
---


Ship it!




Ship It!

- Vinod Kone


On July 19, 2016, 7:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 19, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 3bb64995c076a8f6a09d4bacde4335c6fb8ade78 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/
---

(Updated July 19, 2016, 7:48 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Removed unnecessary await from test.


Diffs (updated)
-

  src/tests/master_slave_reconciliation_tests.cpp 
3bb64995c076a8f6a09d4bacde4335c6fb8ade78 

Diff: https://reviews.apache.org/r/49892/diff/


Testing
---

make check --gtest_repeat=100


Thanks,

Joerg Schad

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-18 Thread Vinod Kone 


> On July 12, 2016, 12:08 a.m., Vinod Kone wrote:
> >

ping?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141806
---


On July 11, 2016, 2:04 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141806
---




src/tests/master_slave_reconciliation_tests.cpp (lines 617 - 618)


don't need these as well?


- Vinod Kone


On July 11, 2016, 2:04 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141700
---


Ship it!




Ship It!

- Neil Conway


On July 11, 2016, 2:04 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141694
---



Patch looks great!

Reviews applied: [49892]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 11, 2016, 2:04 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/
---

(Updated July 11, 2016, 2:04 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Removed unnecessary await from test.


Diffs (updated)
-

  src/tests/master_authorization_tests.cpp 
e43b264b9f67d4cd965aee143cc42a1034ac9952 
  src/tests/master_slave_reconciliation_tests.cpp 
69ec707d4f7c16743a756ad14005cc84a8cdcc54 

Diff: https://reviews.apache.org/r/49892/diff/


Testing
---

make check --gtest_repeat=100


Thanks,

Joerg Schad

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141683
---



Patch looks great!

Reviews applied: [49892]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 11, 2016, 12:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 12:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141679
---




src/tests/master_slave_reconciliation_tests.cpp (line 600)


Should we check that the status update is for the `TASK_RUNNING` state?


- Neil Conway


On July 11, 2016, 12:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49892/
> ---
> 
> (Updated July 11, 2016, 12:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unnecessary await from test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 69ec707d4f7c16743a756ad14005cc84a8cdcc54 
> 
> Diff: https://reviews.apache.org/r/49892/diff/
> 
> 
> Testing
> ---
> 
> make check --gtest_repeat=100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Removed unnecessary await from test.


Diffs
-

  src/tests/master_authorization_tests.cpp 
e43b264b9f67d4cd965aee143cc42a1034ac9952 
  src/tests/master_slave_reconciliation_tests.cpp 
69ec707d4f7c16743a756ad14005cc84a8cdcc54 

Diff: https://reviews.apache.org/r/49892/diff/


Testing
---

make check --gtest_repeat=100


Thanks,

Joerg Schad