Re: Review Request 50064: Added setns and active user test binaries.

2016-07-29 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

(Updated July 30, 2016, 1:30 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added setns and active user test binaries.


Diffs (updated)
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
41e792a2c9ec588d4897d60d012e67c606bbe601 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-29 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

(Updated July 30, 2016, 12:29 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added setns and active user test binaries.


Diffs (updated)
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
41e792a2c9ec588d4897d60d012e67c606bbe601 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-28 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/#review144011
---


Ship it!




LGTM!


src/tests/CMakeLists.txt (line 26)


This TODO still seems relevant.  I'll add it back in before committing.


- Joseph Wu


On July 21, 2016, 11:37 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50064/
> ---
> 
> (Updated July 21, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added setns and active user test binaries.
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/MesosTestsConfigure.cmake 
> caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
>   src/tests/containerizer/CMakeLists.txt 
> 41e792a2c9ec588d4897d60d012e67c606bbe601 
> 
> Diff: https://reviews.apache.org/r/50064/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-21 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

(Updated July 21, 2016, 11:55 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added setns and active user test binaries.


Diffs (updated)
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
41e792a2c9ec588d4897d60d012e67c606bbe601 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/#review142473
---



Patch looks great!

Reviews applied: [50064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 15, 2016, 10:18 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50064/
> ---
> 
> (Updated July 15, 2016, 10:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added setns and active user test binaries.
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/MesosTestsConfigure.cmake 
> caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
>   src/tests/containerizer/CMakeLists.txt 
> 41e792a2c9ec588d4897d60d012e67c606bbe601 
> 
> Diff: https://reviews.apache.org/r/50064/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-15 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

(Updated July 15, 2016, 10:18 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Added setns and active user test binaries.


Diffs (updated)
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
41e792a2c9ec588d4897d60d012e67c606bbe601 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50064: Added setns and active user test binaries.

2016-07-15 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

(Updated July 15, 2016, 9:56 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added setns and active user test binaries.


This adds build steps to build executables active-user-test-helper and 
setns-test-helper(linux only) along with mesos-containerizer-memory_test. The 
binaries help in running some tests with specific user and set namespace and 
memory for some container testing.


Diffs
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
dab8cb07f09f5554123ede4ec8b45b60abf62eee 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu

Review Request 50064: Added setns and active user test binaries.

2016-07-15 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50064/
---

Review request for mesos.


Repository: mesos


Description
---

Added setns and active user test binaries.


This adds build steps to build executables active-user-test-helper and 
setns-test-helper(linux only) along with mesos-containerizer-memory_test. The 
binaries help in running some tests with specific user and set namespace and 
memory for some container testing.


Diffs
-

  src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
  src/tests/cmake/MesosTestsConfigure.cmake 
caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf 
  src/tests/containerizer/CMakeLists.txt 
dab8cb07f09f5554123ede4ec8b45b60abf62eee 

Diff: https://reviews.apache.org/r/50064/diff/


Testing
---

cmake .. && make check


Thanks,

Srinivas Brahmaroutu