Re: Review Request 50186: Avoid a GMock warning in a reservation test case.
> On July 21, 2016, 12:08 p.m., Alexander Rukletsov wrote: > > If we are not interested in rescinding, can't we simply say something like > > ``` > > EXPECT_CALL(sched, offerRescinded(, _)) > > .WillRepeatedly(Return()); > > ``` We could -- I felt like there was value in being a bit more explicit though. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review143077 --- On July 19, 2016, 9:55 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50186/ > --- > > (Updated July 19, 2016, 9:55 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Depending on timing, the master might rescind an offer, which causes a > GMock warning. It is better to wait for the offer and then wait for it > to be rescinded. > > > Diffs > - > > src/tests/reservation_tests.cpp 26bd762db657d5c83cf4b7575ecbbbc26e95d917 > > Diff: https://reviews.apache.org/r/50186/diff/ > > > Testing > --- > > `./src/mesos-tests > --gtest_filter="ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes" > --verbose --gtest_repeat=400` > > Without the patch, emits a GMock warning on ~1% of runs. With the patch, does > not emit the warning. Note that the warning seems to occur more often if you > remove the `os::sleep` from `Clock::settle`, which we want to do anyway. > > > Thanks, > > Neil Conway > >
Re: Review Request 50186: Avoid a GMock warning in a reservation test case.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review143077 --- If we are not interested in rescinding, can't we simply say something like ``` EXPECT_CALL(sched, offerRescinded(, _)) .WillRepeatedly(Return()); ``` - Alexander Rukletsov On July 19, 2016, 9:55 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50186/ > --- > > (Updated July 19, 2016, 9:55 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Depending on timing, the master might rescind an offer, which causes a > GMock warning. It is better to wait for the offer and then wait for it > to be rescinded. > > > Diffs > - > > src/tests/reservation_tests.cpp 26bd762db657d5c83cf4b7575ecbbbc26e95d917 > > Diff: https://reviews.apache.org/r/50186/diff/ > > > Testing > --- > > `./src/mesos-tests > --gtest_filter="ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes" > --verbose --gtest_repeat=400` > > Without the patch, emits a GMock warning on ~1% of runs. With the patch, does > not emit the warning. Note that the warning seems to occur more often if you > remove the `os::sleep` from `Clock::settle`, which we want to do anyway. > > > Thanks, > > Neil Conway > >
Re: Review Request 50186: Avoid a GMock warning in a reservation test case.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review142746 --- Patch looks great! Reviews applied: [50186] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 19, 2016, 9:55 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50186/ > --- > > (Updated July 19, 2016, 9:55 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > --- > > Depending on timing, the master might rescind an offer, which causes a > GMock warning. It is better to wait for the offer and then wait for it > to be rescinded. > > > Diffs > - > > src/tests/reservation_tests.cpp 26bd762db657d5c83cf4b7575ecbbbc26e95d917 > > Diff: https://reviews.apache.org/r/50186/diff/ > > > Testing > --- > > `./src/mesos-tests > --gtest_filter="ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes" > --verbose --gtest_repeat=400` > > Without the patch, emits a GMock warning on ~1% of runs. With the patch, does > not emit the warning. Note that the warning seems to occur more often if you > remove the `os::sleep` from `Clock::settle`, which we want to do anyway. > > > Thanks, > > Neil Conway > >
Re: Review Request 50186: Avoid a GMock warning in a reservation test case.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/ --- (Updated July 19, 2016, 9:55 a.m.) Review request for mesos and Alexander Rukletsov. Repository: mesos Description --- Depending on timing, the master might rescind an offer, which causes a GMock warning. It is better to wait for the offer and then wait for it to be rescinded. Diffs - src/tests/reservation_tests.cpp 26bd762db657d5c83cf4b7575ecbbbc26e95d917 Diff: https://reviews.apache.org/r/50186/diff/ Testing (updated) --- `./src/mesos-tests --gtest_filter="ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes" --verbose --gtest_repeat=400` Without the patch, emits a GMock warning on ~1% of runs. With the patch, does not emit the warning. Note that the warning seems to occur more often if you remove the `os::sleep` from `Clock::settle`, which we want to do anyway. Thanks, Neil Conway
