Re: Review Request 50269: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 25, 2016, 5:20 p.m.) Review request for mesos and Jie Yu. Changes --- Simplified test helper implementation. Bugs: MESOS-5228 https://issues.apache.org/jira/browse/MESOS-5228 Repository: mesos Description --- This test is based on the work in https://reviews.apache.org/r/46371/. Diffs (updated) - src/Makefile.am 69e56551f0adca6d6a9811cafea9a8d3c56d1df9 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50269/diff/ Testing --- `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations) Thanks, Benjamin Bannier
Re: Review Request 50269: Added basic tests for capabilities API.
> On Aug. 17, 2016, 6:29 p.m., Jie Yu wrote: > > FYI: > > https://issues.apache.org/jira/browse/MESOS-6053 https://reviews.apache.org/r/51195 - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/#review146027 --- On Aug. 12, 2016, 4:49 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50269/ > --- > > (Updated Aug. 12, 2016, 4:49 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5228 > https://issues.apache.org/jira/browse/MESOS-5228 > > > Repository: mesos > > > Description > --- > > This test is based on the work in https://reviews.apache.org/r/46371/. > > > Diffs > - > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/tests/capabilities_test_helper.hpp PRE-CREATION > src/tests/capabilities_test_helper.cpp PRE-CREATION > src/tests/capabilities_test_helper_main.cpp PRE-CREATION > src/tests/capabilities_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50269/diff/ > > > Testing > --- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 50269: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/#review146027 --- FYI: https://issues.apache.org/jira/browse/MESOS-6053 - Jie Yu On Aug. 12, 2016, 4:49 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50269/ > --- > > (Updated Aug. 12, 2016, 4:49 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5228 > https://issues.apache.org/jira/browse/MESOS-5228 > > > Repository: mesos > > > Description > --- > > This test is based on the work in https://reviews.apache.org/r/46371/. > > > Diffs > - > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/tests/capabilities_test_helper.hpp PRE-CREATION > src/tests/capabilities_test_helper.cpp PRE-CREATION > src/tests/capabilities_test_helper_main.cpp PRE-CREATION > src/tests/capabilities_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50269/diff/ > > > Testing > --- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 50269: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 12, 2016, 6:49 p.m.) Review request for mesos and Jie Yu. Changes --- Polishing. Bugs: MESOS-5228 https://issues.apache.org/jira/browse/MESOS-5228 Repository: mesos Description --- This test is based on the work in https://reviews.apache.org/r/46371/. Diffs (updated) - src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50269/diff/ Testing --- `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations) Thanks, Benjamin Bannier
Re: Review Request 50269: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 9, 2016, 2:30 p.m.) Review request for mesos and Jie Yu. Changes --- Rebased. Bugs: MESOS-5228 https://issues.apache.org/jira/browse/MESOS-5228 Repository: mesos Description --- This test is based on the work in https://reviews.apache.org/r/46371/. Diffs (updated) - src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50269/diff/ Testing --- `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations) Thanks, Benjamin Bannier
Review Request 50269: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5228 https://issues.apache.org/jira/browse/MESOS-5228 Repository: mesos Description --- This test is based on the work in https://reviews.apache.org/r/46371/. Diffs - src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/50269/diff/ Testing --- `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations) Thanks, Benjamin Bannier
